Navigation Editor: Fix React warning #32165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
adamziel,
draganescu,
getdave,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
Mamaduka
added
[Package] Edit Navigation
[Type] Code Quality
|
Size Change: -2 B (0%) Total Size: 1.86 MB
ℹ️ View Unchanged
|
|
Thanks for the review, @kevin940726. |
|
Looks like there's a rebasing error in this branch? |
Mamaduka
force-pushed
the
fix/nav-editor-react-warning
branch
from
d5a5a27 to
fdef07a
Compare
Remove unnecessary Fragment wrapper.
|
@kevin940726 yeah, the first rebase failed for now reason. But I think it should be fixed now. |
Mamaduka
force-pushed
the
fix/nav-editor-react-warning
branch
from
fdef07a to
ea9e320
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
nameprop returned byuseMenuEntityPropcan beundefined. This inadvertently causes warnings in React by changing between uncontrolled and controlled inputs.How has this been tested?
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).