Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for render_block_core_loginout function #32158

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

david-binda
Copy link
Contributor

Description

The docblock related to register_block_core_loginout function refers to core/latest-posts, while it should be using the core/loginout similarly to the render_block_core_loginout function in the same file.

This comit updates the reference the way it matches the block in question.

How has this been tested?

Documentation only change. Was not really tested.

Screenshots

Not applicable.

Types of changes

Code documentaiton update.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

The docblock related to `register_block_core_loginout` function refers to `core/latest-posts`, while it should be using the `core/loginout` similarly to the `render_block_core_loginout` function in the same file.

This comit updates the reference the way it matches the block in question.
@david-binda david-binda requested a review from ajitbohra as a code owner May 24, 2021 13:42
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix 👍🏻

@gziolo gziolo added the [Type] Code Quality Issues or PRs that relate to code quality label May 24, 2021
@gziolo gziolo added this to the Gutenberg 10.7 milestone May 24, 2021
@youknowriad youknowriad removed this from the Gutenberg 10.7 milestone May 26, 2021
@gziolo gziolo merged commit 75e2626 into WordPress:trunk Jun 7, 2021
@github-actions github-actions bot added this to the Gutenberg 10.9 milestone Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants