Editor package: no-string-literals fix #32153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -140 B (0%) Total Size: 1.86 MB
ℹ️ View Unchanged
|
aristath
force-pushed
the
fix/no-string-literals/editor
branch
2 times, most recently
from
eeb9bf9 to
72de023
Compare
aristath
force-pushed
the
fix/no-string-literals/editor
branch
from
72de023 to
0909598
Compare
jorgefilipecosta
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes eslint warnings in the editor package, replaces string literals with store definitions.
Part of #27088.
How has this been tested?
npm run lint-js packages/editor/no longer throws warnings for string literalsNote: There is 1 warning remaining for
'core/data'but I couldn't replace it in this PR because thedatapackage doesn't have astore. We'll need to dig a bit deeper for that one.Checklist:
*.native.jsfiles for terms that need renaming or removal).