Prepare for adding the Widgets block editor to Core #32136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes two changes required to add the Widgets block editor to Core: - Marks the @wordpress/customize-widgets package as non-private so that it can be required by Core's package.json. - Marks the Legacy Widget block as stable so that registerCoreBlocks() will register it.
noisysocks
added
[Feature] Widgets Screen
noisysocks
requested review from
adamziel,
ajitbohra,
draganescu,
kevin940726,
talldan and
tellthemachines
as code owners
noisysocks
added
the
Backport to WP 6.7 Beta/RC
noisysocks
force-pushed
the
add/changes-needed-to-add-widgets-to-core
branch
from
c255faf to
6c0ec79
Compare
kevin940726
reviewed
May 24, 2021
|
Size Change: -42 B (0%) Total Size: 1.86 MB
ℹ️ View Unchanged
|
talldan
reviewed
May 24, 2021
| enableLegacyWidgetBlock: true, | ||
| } ); | ||
| } | ||
| __experimentalRegisterExperimentalCoreBlocks(); |
There was a problem hiding this comment.
@noisysocks I think this should be behind the Gutenberg phase flag like it was before.
There was a problem hiding this comment.
I guess we only needed to remove the enableLegacyWidgetBlock option (and options object) being passed as an argument.
There was a problem hiding this comment.
Oh, I see #32138 now, ignore this!
gziolo
pushed a commit
that referenced
this pull request
May 24, 2021
|
Cherry-picked to the Gutenberg 10.7 release. |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes two changes required to add the Widgets block editor to Core (https://core.trac.wordpress.org/ticket/51506):
@wordpress/customize-widgetspackage as non-private so that it can be required by Core's package.json.registerCoreBlocks()will register it.I decided to enable Legacy Widget everywhere because:
To test: