Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icons] Expose trendingDown and trendindUp icons #32124

Merged
merged 1 commit into from
Jun 11, 2021
Merged

[Icons] Expose trendingDown and trendindUp icons #32124

merged 1 commit into from
Jun 11, 2021

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented May 22, 2021 •
edited by ntsekouras
Loading

This PR exposes trendingDown and trendindUp icons.

@ntsekouras ntsekouras changed the title Fix: Add unloaded components [Icons] Expose trendingDown and trendindUp icons Jun 10, 2021
@ntsekouras ntsekouras added the [Package] Icons /packages/icons label Jun 10, 2021
@ntsekouras
Copy link
Contributor

ntsekouras commented Jun 10, 2021 •
edited
Loading

Thanks for the PR @t-hamano !

@jasmussen these icons are not used in GB but exist there 😄 .

Do we want to expose them or they are leftovers to be removed? PR that introduced them is here: #21209.

@ntsekouras ntsekouras requested a review from jasmussen June 10, 2021 15:42
jasmussen
jasmussen approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a curious oversight! I checked the SVGs:

Screenshot 2021-06-11 at 08 33 35

And it matches what's in the Figma:

Screenshot 2021-06-11 at 08 33 54

I actually dislike the rounded endcap on the arrow 🙈 — but that's a separate item. They exist, and as such we might as well expose them. Thanks for the PR!

@ntsekouras ntsekouras merged commit 045f329 into WordPress:trunk Jun 11, 2021
@github-actions github-actions bot added this to the Gutenberg 10.9 milestone Jun 11, 2021
@t-hamano t-hamano deleted the patch-1 branch June 28, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@jasmussen jasmussen jasmussen approved these changes

Assignees
No one assigned
Labels
[Package] Icons /packages/icons
Projects
None yet
Milestone
Gutenberg 10.9
Development

Successfully merging this pull request may close these issues.
3 participants
@t-hamano @ntsekouras @jasmussen