BlockTitle: avoid re-render on attributes change #32118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -38 B (0%) Total Size: 1.86 MB
ℹ️ View Unchanged
|
|
@ramonjd, I think some of these optimizations could apply to the new |
Thanks for the ping. It definitely makes sense to encapsulate some of that logic in the selector. And it looks neater. :) I've started it off over at https://github.com/WordPress/gutenberg/pull/40004/files The tests will have to be refactored significantly to cover the logic as well. I'd be interested to know if it's something that is causing issues. I guess not since the PR description doesn't mention it. I've done a small comparison using Flamegraph and the visual render tool, and I can't see where we're triggering Block Title re-renders in trunk and with the changes.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just a small optimisation. The block attributes object should not be returned by the selector.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).