Navigation Editor: Move modal state to ManageLocations component #32078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
requested review from
adamziel,
draganescu,
getdave,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
|
Size Change: -109 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
getdave
approved these changes
May 21, 2021
There was a problem hiding this comment.
So I've got mixed feelings about this one.
On one hand you're completely right that as of now we have no use cases where we need to manage the modal state outside of the component.
That said, I suspect we may do in future as the Navigation Editor changes.
Overall, however, I'm inclined to approve this as there's little point in retaining complexity when there are no known use cases to support it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves modal state from
useNavigationEditortoManageLocationscomponent and manage it locally.Fixes #31837.
How has this been tested?
Types of changes
Code Quality
Checklist:
*.native.jsfiles for terms that need renaming or removal).