Block: Assign block list ref from block child #3205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced in #3171
This pull request is a partial revert of #3171, seeking to address an error which occurs when removing a block. The changes in #3171 depend to access props of a rendered element ref are insufficient, since the
ref
callback is invoked withnull
when the element unmounts. The changes here partially restore the original behavior prior to #3171, with an optimization to still use a constant reference to binding the blockref
in VisualEditorBlockList by passing UID from the child Block component's ownref
callback.Testing instructions:
Verify that no errors occur when removing a block.