Popover: remove unused content property from types definitions
#32049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Feature] UI Components
sarayourfriend
approved these changes
May 20, 2021
|
Size Change: 0 B Total Size: 1.86 MB ℹ️ View Unchanged
|
tyxla
approved these changes
May 20, 2021
ciampo
force-pushed
the
feat/popover-remove-unused-prop-content
branch
2 times, most recently
from
a66866d to
ad7584a
Compare
|
Rebased on top of latest |
ciampo
force-pushed
the
feat/popover-remove-unused-prop-content
branch
3 times, most recently
from
713b325 to
b6edbf9
Compare
ciampo
force-pushed
the
feat/popover-remove-unused-prop-content
branch
from
b6edbf9 to
03ceb67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the
contentprop from the<Popover />component (the g2 version), since it doesn't seem to be used anywhere (and was not documented anyway).I tried to look in the
g2repo's history, but I couldn't find any usages.Testing instructions
@wordpress/componentspackage builds correctly and all unit tests passScreenshots
N/A
Types of changes
Refactor (dead code removal)
Checklist:
*.native.jsfiles for terms that need renaming or removal).