-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compose: useMergeRefs: add test for disabling refs + better docs #32044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
ellatrix
changed the title
Compose: useMergeRefs: add test for disabling refs
Compose: useMergeRefs: add test for disabling refs + better docs
May 20, 2021
ellatrix
force-pushed
the
add/disable-merged-ref-test
branch
from
May 20, 2021 14:32
e8b3fa2
to
7c24f0d
Compare
ellatrix
force-pushed
the
add/disable-merged-ref-test
branch
from
May 20, 2021 14:40
7c24f0d
to
a45fbcd
Compare
ellatrix
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Type] Developer Documentation
Documentation for developers
[Package] Compose
/packages/compose
labels
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Compose
/packages/compose
[Type] Code Quality
Issues or PRs that relate to code quality
[Type] Developer Documentation
Documentation for developers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a test for disabling refs through
useMergeRefs
. This didn't work until #31714 because it would throw an errorTypeError: previousRef is not a function
, which is why I'm adding a test now to avoid regressing.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).