Try stabilizing customize widgets e2e tests #32023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Feature] Widgets Customizer
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
talldan
deleted the
add/wait-for-widget-block-library-panel-animation-in-e2e-test
branch
talldan
added
the
[Type] Task
ellatrix
reviewed
May 20, 2021
| // | ||
| // eslint-disable-next-line no-restricted-syntax | ||
| await page.waitForTimeout( 300 ); | ||
|
|
||
| const blockOption = await find( { | ||
| role: 'option', | ||
| name: blockName, |
There was a problem hiding this comment.
Can't we use normal selectors here? And then we can just wait for the selector?
There was a problem hiding this comment.
Ah, I guess that wouldn't work with the animation anyway.
There was a problem hiding this comment.
find does wait for the element, but yeah, the problem wasn't about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempts to solve the intermittent failure in the customize widgets tests observed here - https://github.com/WordPress/gutenberg/runs/2620274056.
The test attempts to insert a paragraph and a heading, and then use the trailing appender to add a Search block.
But the test failure snapshots show that the test is sometimes inserting two paragraphs instead.
My guess is that the Paragraph is incorrectly inserted due to the animation the block library panel has in the customizer. The test is attempting to click the Heading block while the animation is happening, but clicks the Paragraph block that's next to it.
There isn't a trailing appender in this situation, because the appender doesn't appear after paragraphs, so the test fails.
This PR adds a timeout to wait for the animation to finish. The animation is 0.18 seconds, so waiting 300ms should be plenty.
(edit: animations could be disabled entirely in e2e tests when this issue is solved - #32024)