Post content block: apply the_content filter before checking if content is empty #31997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcsf I see you were the last one to make changes in this file, do you mind taking a look at this PR or marking somebody else for review? Thanks! |
mcsf
approved these changes
May 19, 2021
There was a problem hiding this comment.
@Aljullu: the fix itself looks good, feel free to merge.
I see you were the last one to make changes in this file, do you mind taking a look at this PR or marking somebody else for review?
For what it's worth, this issue stems from the branching introduced in #30961, which sought to avoid printing empty containers in the front end by returning early from render_block_core_post_content. @carolinan, @aristath: just flagging this for you, as it highlights some pitfalls of #30571 (reductions aren't necessarily simplifications).
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
Aljullu
force-pushed
the
fix/apply-the_content-filter-before-empty-check
branch
from
f609d6d to
adf28af
Compare
aristath
approved these changes
May 20, 2021
Aljullu
force-pushed
the
fix/apply-the_content-filter-before-empty-check
branch
from
adf28af to
12819ca
Compare
|
All green after rebase. I could merge it. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31995.
Description
This PR reorders the render logic of the Post content block so
the_contentfilter is applied before the early return for empty content.How has this been tested?
the_contentfilter to append the Shop page contents. I tested that when the page has no text, Shop contents are displayed.Step-by-step reproduction instructions
Filtered --prefix.