Update tests for changes in core logic #31982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
changed the title
ellatrix
reviewed
May 19, 2021
| @@ -576,7 +576,7 @@ function test_remove_insecure_properties_removes_unsafe_styles_sub_properties() | |||
| 'padding' => array( | |||
| 'top' => '1px', | |||
| 'right' => '1px', | |||
| 'bottom' => 'var(--unsafe-var-toplevel)', | |||
There was a problem hiding this comment.
Btw, I noticed when you insert HTML here, it's not stripped.
|
A rebase should make e2e tests green too. |
ellatrix
approved these changes
May 19, 2021
oandregal
force-pushed
the
update/filter-kses
branch
from
df7fe7a to
519d8d8
Compare
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core got support for
var()andcalc()in WordPress/wordpress-develop@8e498a8 Because we don't pin the core versions, this has resulted in failures in our tests. This PR updates the tests to the new core code.Props to @ellatrix and @ockham for the sleuthing.