Fix moving animation for nested blocks #31945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
May 18, 2021
| return { | ||
| index: getBlockIndex( clientId ), | ||
| index: getBlockIndex( clientId, rootClientId ), |
There was a problem hiding this comment.
It seems strange that the root client ID needs to be passed if it can be derived from the client ID.
There was a problem hiding this comment.
It might not be the only selector like that.
youknowriad
approved these changes
May 18, 2021
|
Size Change: +14 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
fix/moving-animation-nested-blocks
branch
from
0d85344 to
65d38aa
Compare
ellatrix
force-pushed
the
fix/moving-animation-nested-blocks
branch
from
65d38aa to
282389b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).