Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHPCS warning for alignment #31931

Merged
merged 1 commit into from
May 18, 2021
Merged

Fix PHPCS warning for alignment #31931

merged 1 commit into from
May 18, 2021

Conversation

aristath
Copy link
Member

Description

A simple coding-standards fix.
Doesn't change anything.

How has this been tested?

It hasn't been tested, there's nothing to test.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@aristath aristath added the [Type] Code Quality Issues or PRs that relate to code quality label May 18, 2021
@aristath aristath requested a review from carolinan May 18, 2021 10:04
gziolo
gziolo approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@aristath aristath merged commit 8ccf055 into trunk May 18, 2021
@aristath aristath deleted the fix/phpcs-alignment branch May 18, 2021 13:34
@github-actions github-actions bot added this to the Gutenberg 10.7 milestone May 18, 2021
@ellatrix
Copy link
Member

Why was this merged with failing tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@carolinan carolinan Awaiting requested review from carolinan

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

Assignees
No one assigned
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 10.7
Development

Successfully merging this pull request may close these issues.
3 participants
@aristath @ellatrix @gziolo