-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nav block hover z index. #31929
Merged
Merged
Fix nav block hover z index. #31929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Block] Navigation
Affects the Navigation Block
CSS Styling
Related to editor and front end styles, CSS-specific issues.
labels
May 18, 2021
priethor
approved these changes
May 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm, thanks! 🚀
Grabacion.de.pantalla.2021-05-18.a.las.11.18.00.mov
Thanks! |
Size Change: +58 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
jasmussen
force-pushed
the
fix/nav-z-index
branch
4 times, most recently
from
May 19, 2021 06:17
3005510
to
5736221
Compare
jasmussen
force-pushed
the
fix/nav-z-index
branch
from
May 19, 2021 10:21
5736221
to
be08eb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Navigation
Affects the Navigation Block
CSS Styling
Related to editor and front end styles, CSS-specific issues.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the editor, you can click to open submenus and they will stay open. You can also hover to open submenus. So if you have one open, then hover another, you'll show two submenus. That's fine, but the z-index was wrong:
This PR fixes it:
How has this been tested?
Insert a navibation menu where two adjacent menu items have submenus.
Click inside one submenu to "pin it" open.
Then hover the adjacent submenu, and verify that it overlays the pinned open menu.
Checklist:
*.native.js
files for terms that need renaming or removal).