Babel Preset Default: Configure @babel/preset-env preset to respect a local Browserslist configuration #31898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2021
|
Size Change: +156 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
gziolo
added
[Tool] Babel preset
gziolo
reviewed
May 18, 2021
gziolo
reviewed
May 18, 2021
ocean90
force-pushed
the
feature/babel-preset-default-browserslist-config
branch
from
c01d303 to
9898955
Compare
gziolo
approved these changes
May 18, 2021
ocean90
force-pushed
the
feature/babel-preset-default-browserslist-config
branch
from
49ddc49 to
315e1ba
Compare
|
In fact, it's going to be useful for Gutenberg itself because it will finally use the top-level config :) https://github.com/WordPress/gutenberg/blob/trunk/.browserslistrc I tested locally and it loads it correctly now 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This uses browserslist.findConfig() to first search for a local config before falling back to
@wordpress/browserslist-config.Fixes #31857.
How has this been tested?
To verify what targets are used you can set
opts.debug = trueafter line 37Before:
After (with
@wearerequired/browserslist-config):Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).