Fix e2e test inserting cover block #31866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
ntsekouras
reviewed
May 17, 2021
| // Wait for the search results to load after typing the full search | ||
| // term. Previously this test would sometimes accidentally tab to the | ||
| // button for a code block. | ||
| await page.evaluate( () => new Promise( window.requestIdleCallback ) ); |
There was a problem hiding this comment.
I don't believe this check would necessarily run the scheduled event we are looking for (load search results) always.
This can still cause intermittent failures and it does in trunk.
I've changed this check here: b928438 which will land now with a green CI.
There was a problem hiding this comment.
That's what we had before, which was also failing sometimes. But the failures happen more now. I'll just revert my PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See comment.
With the
insertBlockutility function we don't useTabbutclickinstead, which explains why there's no intermittent failures there.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).