Fix intermittent failure of rich text e2e test #31864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +23 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
ellatrix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem here is that we were pressing cmd+A on an already fully selected text, trigger multi selection, which was setting a multi selection on a single block, which doesn't work.
There's a problem on a few levels:
splitfrom rich text returns the given value twice when splitting with anundefinedselection. That's at all not expected, so we should either return nothing or (type) error. If we had done that, the problem would be more obvious.Multi selection should not be possible on a single block. Ideally we should error in
multiSelect(I think), but I opted here for checking before callingmultiSelect. Worth noting that in the future we might want to allow a "full" selection of a single block.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).