Fix flaky change detection tests causing intermittent failures #31861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
May 15, 2021
| @@ -302,14 +305,17 @@ describe( 'Change detection', () => { | |||
| // Keyboard shortcut Ctrl+S save. | |||
| await pressKeyWithModifier( 'primary', 'S' ); | |||
There was a problem hiding this comment.
If you insert await page.evaluate( () => new Promise( window.requestIdleCallback ) ); after this line, the problem can be consistently reproduced, as you would expect. So if the test runs slow, the tests fails.
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem here is that we're dirtying the post, which will replace the "Saved" text with the "Save" button, so checking the saved state after dirtying the post might not work.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).