Global Styles: Allow custom properties to merge #31840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Question
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
|
[edit]. I had some thoughts and went back-and-forth with myself but no longer agree with myself. Myself and I are no longer speaking about this matter so I look forward to other people's thoughts and reasonings instead. |
|
Is there an alternative that doesn't involve adapting the The way we deal with this in the site editor is by doing the merge in the UI: when a user adds a new color, we merge it with the colors of the theme and store them all in the user CPT. Same when the user changes the value of a color provided by a theme. Can you perhaps do the same? |
|
Yes we definitely can, but I'm curious as to why it was decided not to merge |
|
Actually. So far, You may need to rebase this from |
oandregal
approved these changes
Jun 23, 2021
oandregal
added
the
Backport to WP 6.7 Beta/RC
scruffian
force-pushed
the
update/theme-json-merge
branch
from
ce902ca
to
1d079cc
Compare
scruffian
force-pushed
the
update/theme-json-merge
branch
from
6436d5a
to
1d079cc
Compare
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more a question/discussion than a proposal.
I am modifying the user data for theme.json (the CPT) from outside of the Site Editor (using the Customizer), by adding properties to
settings.custom. When I do this I wantsettings.customfrom the theme.json itself to be merged with the settings from the CPT. This line wipes out the contents of settings.custom from theme.json and replaces it with the data in the CPT. I assume it's here for a good reason though.