-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post terms: Add a CSS class to identify the taxonomy #31832
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +9 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
carolinan
added
[Block] Post Tags
Affects the Post Tags Block
[Block] Post Terms
Affects the Post Terms Block
labels
May 17, 2021
ntsekouras
force-pushed
the
update/post-terms-identifier
branch
from
May 17, 2021 12:14
e2ee1f2
to
c25f73b
Compare
ntsekouras
approved these changes
May 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Carolina! I rebased as the tests were fixed on trunk just a bit earlier.
This will just need a rebase to make tests pass. |
aristath
force-pushed
the
update/post-terms-identifier
branch
from
May 19, 2021 13:59
0799725
to
ce4cba5
Compare
rebased the branch 👍 |
ntsekouras
force-pushed
the
update/post-terms-identifier
branch
from
June 11, 2021 10:08
ce4cba5
to
c25f73b
Compare
ntsekouras
force-pushed
the
update/post-terms-identifier
branch
from
June 11, 2021 10:11
c25f73b
to
71d8033
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #31617 by adding the CSS class
taxonomy-
followed by the term attribute (This may sound backwards but the block's terms attribute is the taxonomy).How has this been tested?
Tested manually by adding post categories and post tags block variation in the editor
and the viewing the source to confirm that the class is added both in the editor and the front.
Types of changes
Enhancement
Checklist:
*.native.js
files for terms that need renaming or removal).