-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mobile context in settings request & global styles #31819
Conversation
@geriux I've added the |
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
Thanks for doing that! I think we already have what we need in this PR 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, tested it by passing the mobile
context and it's returning the needed data. Thanks!
Follows up to #31762 and #29969 (comment)
We're defining some "contexts" to provide settings to, including
post-editor
,site-editor
, orwidgets-editor
. We'll use those contexts to filter what kind of data we pass through the REST request. We also plan to move the settings retrieval to use the REST request.This PR adds a new context,
mobile
, and declares its specific data requests.