-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image/Gallery block: remove use of unstableOnFocus #31796
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
commented
May 13, 2021
Size Change: -133 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
ellatrix
changed the title
Image block: remove use of unstableOnFocus
Image/Gallery block: remove use of unstableOnFocus
May 13, 2021
Closed
2 tasks
AmandaRiu
pushed a commit
that referenced
this pull request
May 18, 2021
This reverts commit 9a6e3fc.
AmandaRiu
pushed a commit
that referenced
this pull request
May 19, 2021
This reverts commit 9a6e3fc.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Builds in selection changing when an element outside of rich text receives focus. This reduces complexity for the block author as they no longer need to manage selection state of rich text fields for more complex blocks.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).