BoxControl: Filter out unit only values when checking values defined #31779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
aaronrobertshaw
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: +3 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
May 14, 2021
This prevents a false positive when the box control checks whether it has any unlinked values defined.
aaronrobertshaw
force-pushed
the
fix/box-control-mixed-placeholder-when-empty
branch
from
90a8fc0 to
5cb80af
Compare
ramonjd
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue when if a BoxControl's unit is changed while the field is empty the input gets the "mixed" placeholder text.
How has this been tested?
Manually.
Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).