Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parsing and retrieve additional data in REST url-details endpoint #31763

Merged
merged 34 commits into from
May 29, 2021
Merged

Improve parsing and retrieve additional data in REST url-details endpoint #31763

Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
9449efd
Add basic regex to grab site icon
getdave May 12, 2021
e381228
Retrieve meta description
getdave May 19, 2021
d6fd284
Ensure cleanup
getdave May 19, 2021
a26abba
Improve title regex to account for possible attributes on title
getdave May 19, 2021
308fb7c
Retrieve OG Image
getdave May 19, 2021
334495c
Fix linting
getdave May 19, 2021
5c0e553
Fix tests to assert on array subset
getdave May 19, 2021
c38854c
Enhance fixture data with more edge cases
getdave May 19, 2021
a870d2e
Add tests to ensure new properties are captured for icon, description…
getdave May 19, 2021
98d0f84
Add more specific yet flexible test for title
getdave May 19, 2021
11d375f
Handle relative resource URLs for icon and image
getdave May 19, 2021
87f4d33
Use random user agent string to avoid being blocked by certain websites.
getdave May 19, 2021
f25f6da
Account for open graph image property variations
getdave May 19, 2021
1cf283d
Add unit test for get_title
getdave May 19, 2021
a9119bb
Add tests (including some failing) for get_icon
getdave May 19, 2021
9ba3530
Fix method invocation to remove unused args
getdave May 19, 2021
afe0af9
Wrap test HTML string in a basic HTML doc.
getdave May 19, 2021
57d1389
Parse the head section and use for comparison
getdave May 19, 2021
6d83c50
Fix broken cache test
getdave May 19, 2021
c0bee0a
Refine wrap method
getdave May 19, 2021
d740527
Add get_image tests
getdave May 19, 2021
fc65afb
Handle relative URLs when target url has a path
getdave May 19, 2021
cc9cf7f
Improves title and icon parsing for PR 31763 (#32021)
May 20, 2021
2eae9a7
Seek head but fallback to body.
getdave May 20, 2021
04e3e21
Improves metadata parsing for PR 31763 (#32067)
May 24, 2021
411291d
Improves PR 31763 for the URL Details Controller (#32162)
May 25, 2021
1a0f16d
Update lib/class-wp-rest-url-details-controller.php
getdave May 26, 2021
b20b011
Update lib/class-wp-rest-url-details-controller.php
getdave May 26, 2021
df7dd5a
Update lib/class-wp-rest-url-details-controller.php
getdave May 26, 2021
1618f19
Icon: if data url, skip relative-to-absolute conversion (#32276)
May 27, 2021
4d33f54
Fix failing test due to extra character in expected string.
May 27, 2021
a0107f1
Updates schema for new data items.
May 28, 2021
b013a82
Changes icon and image type to uri.
May 28, 2021
0097a74
Schema: icon & image: reverts type back to string and adds format of …
May 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading