[RNMobile] Fix missing title for some unsupported blocks #31743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The block's title is now only translated when is gets registered, for unsupported blocks since they're not registered, title has be explicitly translated.
fluiddot
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
2 tasks
fluiddot
commented
May 12, 2021
| @@ -34,6 +34,7 @@ import styles from './style.scss'; | |||
|
|
|||
| // Blocks that can't be edited through the Unsupported block editor identified by their name. | |||
| const UBE_INCOMPATIBLE_BLOCKS = [ 'core/block' ]; | |||
| const I18N_BLOCK_SCHEMA_TITLE = 'block title'; | |||
There was a problem hiding this comment.
This value was taken from packages/blocks/src/api/i18n-block.json file.
# Conflicts: # packages/react-native-editor/CHANGELOG.md
|
As @ceyhun pointed out in an internal conversation, the titles don't have the proper translations. This is caused by two different issues that are not related to this PR: Extra strings in the main apps (only happening on iOS)Although the unneeded extra strings were already fixed in Missing strings in GutenbergRecently, the block title strings are missing in the Gutenberg localization files so even if we don't overwrite them with the incoming strings from the main apps, we don't have locally the proper translations for the blocks. Here is the issue opened in WordPress.org related to this. |
ceyhun
approved these changes
May 18, 2021
dcalhoun
pushed a commit
that referenced
this pull request
May 21, 2021
* Add get title to missing block The block's title is now only translated when is gets registered, for unsupported blocks since they're not registered, title has be explicitly translated. * Update react-native-editor changelog
AmandaRiu
added a commit
that referenced
this pull request
May 25, 2021
* Release script: Update react-native-editor version to 1.53.0 * Release script: Update with changes from 'npm run core preios' * Update changelog to reflect release * Release script: Update react-native-editor version to 1.53.1 * Release script: Update with changes from 'npm run core preios' * Update react-native-editor changelog * Gallery block: restore focus caption prop for native * [RNMobile] Fix missing title for some unsupported blocks (#31743) * Add get title to missing block The block's title is now only translated when is gets registered, for unsupported blocks since they're not registered, title has be explicitly translated. * Update react-native-editor changelog * Update lock files Co-authored-by: Ceyhun Ozugur <[email protected]> Co-authored-by: Carlos Garcia <[email protected]> Co-authored-by: Ella van Durpe <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3489Description
Block titles are now translated on the fly when they're registered so unsupported blocks, which are not registered, no longer will have the title translated.
This PR introduces the function
getTitleinto the missing block to translate the title the same way we're doing it for registered blocks.Code references:
How has this been tested?
NOTE: Only core blocks (defined here) will display the title, the rest will show the block's name (i.e.:
jetpack/gif).Since this change is also related to translations, we should also perform a test using a different device's language:
Screenshots
In a non-English language:
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).