Spacing Support: Hide UI for disabled properties

[stacimc]

Description

Fixes issue #31725
The Spacing block support has support for both padding and margin independently; it is possible for a theme to opt in to only one or the other. Currently the UI for both is displayed as long as the block supports that feature, and the theme supports either feature. This PR updates the block support to only display the UI if it is supported by both the block and the theme.

How has this been tested?

Manually

To test, you need a block that supports both padding and margin. I used Site Title and updated the block.json to include:

"supports": {
    // ...other supports
    "spacing": {
        "padding": true,
        "margin:": true
    }
}

You also need to update your theme.json to enable customPadding, but disable customMargin:

"settings": {
   "spacing": {
        "customPadding": true,
        "customMargin": false
    }
}

1. Open the site editor and select the Site Title block. View the Inspector Controls and verify that only the Padding controls display.
2. Update the theme.json to set both customMargin and customPadding to true. Verify that now both Margin & Padding controls display.
3. Update theme.json to only enable customMargin, and verify that now only Margin controls display.
4. -Update theme.json to disable both padding and margin, and verify that the Spacing panel is not rendered at all.

Screenshots

The Spacing panel when both Padding & Margin are supported by both the block and the theme:

The Spacing panel when the block supports both Padding & Margin, but the theme only supports Margin:

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• I've tested my changes with keyboard and screen readers.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

[aaronrobertshaw]

Thanks for catching this @stacimc!

The spacing support controls need to check both whether the block opted into the support feature as well as if the theme disabled the UI for that feature.

I mistakenly thought the disabled check didn't take into account the block's support flags and pushed a commit adding it as well. My mistake. That's been reverted. Sorry.

This now tests well for me in both the block editor and site editor.

[ramonjd]

Also working well for me! 🙇