Site Logo block: Only request media entity when we have a site logo chosen #31673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-szabo97
added
[Type] Bug
david-szabo97
requested review from
mattwiebe,
scruffian,
vindl,
creativecoder,
Copons,
jeyip and
Addison-Stavlo
|
Size Change: +5 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
May 11, 2021
david-szabo97
force-pushed
the
fix/site-logo-404-request
branch
from
6483d08 to
8185901
Compare
carolinan
approved these changes
May 12, 2021
david-szabo97
force-pushed
the
fix/site-logo-404-request
branch
from
8185901 to
0bfec8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Site Logo fires a request that always result in a 404:
http://localhost:8888/index.php?rest_route=%2Fwp%2Fv2%2Fmedia%2Fnull&context=edit&_locale=userNotice the
nullin the URL.This PR simply skips the
getEntityRecordselector when thesitelogois empty.How has this been tested?
rest_route=%2Fwp%2Fv2%2Fmediatrunkthen you will see a request with a 404 response)Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).