Cover block: remove fixed background when cover block previewed in patterns list #31640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Bug
|
Size Change: +716 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
kjellr
reviewed
May 10, 2021
| @@ -105,3 +105,7 @@ | |||
| font-size: $default-font-size; | |||
| } | |||
| } | |||
|
|
|||
| .block-editor-block-patterns-list__list-item .has-parallax.wp-block-cover { | |||
There was a problem hiding this comment.
Might be worth adding a code comment to make it clear what this is doing.
|
This seems like a reasonable (and simple!) fix to me. I definitely don't think it's critical to have parallax in the preview panel, but I'd like to cc @jasmussen for a second opinion just to be sure. |
jasmussen
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #30814
If the cover block has parallax set, and is contained in a pattern, the background image does not cover correctly due to the transforms that are applied to resize the block for the pattern preview panel size.
Due to the small size of the pattern preview version it probably makes more sense to just disable the fixed background in the this context.
To test
Before:
After:
