-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich text: extract input and selection #31631
Merged
Merged
+393
−320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +329 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Sep 20, 2022
if ( ! isSelected ) { | ||
// We know for certain that on focus, the old selection is invalid. | ||
// It will be recalculated on the next mouseup, keyup, or touchend | ||
// event. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you remember why we have this comment @ellatrix ?
Is there a way to get the correct "start, end" without waiting for the next event (for performance reasons).
Also, would 0
be a better default than undefined
if not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Preparatory work for putting all rich text behaviours into a single ref callback hook, while also splitting the large rich text file.
How has this been tested?
Nothing should have changed. We have lots of e2e test coverage for this.
Screenshots
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).