[Block Library - Post Featured Image]: Change wrapper element to figure
#31595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
ntsekouras
requested review from
aristath,
jameskoster,
kjellr,
jasmussen and
carolinan
carolinan
approved these changes
May 7, 2021
|
Size Change: +60 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
aristath
approved these changes
May 7, 2021
|
Nice. The only gotcha is the zeroing out of left and right margins. For themes that use margin-left: auto/margin-right: auto plus a max-width to handle full-wide elements, this will align the featured image to the far left. Be sure to test this inside center-column container in some older themes. |
This was used for block themes so not sure what do you mean by older themes? Also by |
Ah, can the featured image block not be used in non block themes?
Sorry that was unclear. No I just mean we need to test the featured image block when inserted in a context that allows wide and fullwide images, and then see how it works. |
It will be from next version (10.6), so I think we are okay on that front, no? --edit: Also tested with alignments inside a group and it seems to be just fine. |
It will be available for non block themes from version 10.6, or it will be unavailable? 😅 I just inserted the post featured image block in TT1 non blocks, and hacked in a zero left margin. And it worked fine, the margin-left: auto overrode it. So I think we're good:
|
It will be available 😄 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #30475
Currently, the Post Featured Image block outputs the featured image wrapped in a paragraph element. A figure element would be more semantic, and match the structure of the gallery and image blocks.