Edit Post: Prevent rendering self also when the wrapper block matches the inserted block #31592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Bug
gziolo
force-pushed
the
fix/recursive-render-wrapper
branch
from
039f7d3 to
493cfaf
Compare
|
Size Change: +127 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
gziolo
commented
May 7, 2021
| const previouslyRenderedBlocks = useContext( RenderedRefsContext ); | ||
| const { name: blockName } = useBlockEditContext(); | ||
| const { name } = useBlockEditContext(); | ||
| blockName = blockName || name; |
There was a problem hiding this comment.
It might be a nice idea to cover it with a unit test. I will explore options next week.
ntsekouras
reviewed
May 7, 2021
Did you re-trigger some CI jobs? I don't see errors. |
ntsekouras
approved these changes
May 7, 2021
gziolo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reportes by @ntsekouras in #31455 (comment):
How has this been tested?
Create a post and insert a Post Content block there.
Convert a block(s) into a Reusable block. Go to Manage Reusable Blocks page and start editing one of them. Insert the same Reusable block into self.
It should not render only the warning as presented below.
Screenshots
Reusable block inserted when editing the post for the same reusable block:
Post Content inserted when editing the same post:
Types of changes
Bug fix (non-breaking change which fixes an issue).
Checklist:
*.native.jsfiles for terms that need renaming or removal).