Clear selected block when focusing on element outside the editor #31530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
|
Size Change: +196 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
noisysocks
approved these changes
May 7, 2021
packages/customize-widgets/src/components/customize-widgets/use-clear-selected-block.js
Show resolved
Hide resolved
kevin940726
force-pushed
the
fix/clear-selected-block-customizer
branch
from
2566a28 to
c730859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #31141.
Listen
focusinandblurevents to handle focusing out of the editor and clear the selected block. We can't just rely on<BlockSelectionClearer>because the elements (editor, inspector, popover, preview iframe) are all over the place rather than only under a parent node. The only solution I can think of for now is to register those events and manually check it.I also moved some common code from the editor to the entry component, hope that this doesn't break anything 😅.
How has this been tested?
Select any block and try to unfocus it by clicking outside the editor. The inspector should still work though.
We can write some e2e tests if it's proved to be needed. Not sure we should do that now though.
Screenshots
Kapture.2021-05-06.at.17.19.04.mp4
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).