compose: Add types useAsyncList #31523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Type] Code Quality
|
Size Change: +581 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
jsnajdr
reviewed
May 6, 2021
| const [ current, dispatch ] = useReducer( | ||
| listReducer as Reducer< T[], ResetAction< T > | AppendAction< T > >, | ||
| [] as T[] | ||
| ); |
There was a problem hiding this comment.
Remember the Redux ducks pattern we discussed few days ago? We could use something similar in this hook:
const [ current, setCurrent ] = useState< T[] >( [] );
setCurrent( firstItems ); // replacement for reset action
setCurrent( state => [ ...state, item ] ); // replacement for append actionThat saves a lot of effort typing the reducer and the actions. Many lines of code can be deleted.
tyxla
reviewed
May 6, 2021
|
@youknowriad what's the best way to test changes to |
|
Just check that the patterns list in the inserter is performant enough. In Safari you'll notice that things appear more slowly but at least it doesn't freeze tab switching. |
|
Try also switching patterns categories back and forth and see that there are no missing patterns or things like that. |
|
Thanks Riad! It seems to work fine for me. @jsnajdr do you want to verify as well and then review the changes? |
jsnajdr
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds types to
useAsyncList. This also simplifies the logic inside ofuseAsyncListto useuseStateinstead ofuseReducer. This removes about a dozen lines of code.Are there unit tests for this function?
How has this been tested?
Type checks and unit tests continue to pass.
Types of changes
Non-breaking changes.
Checklist:
*.native.jsfiles for terms that need renaming or removal).