-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove: __experimentalUseColors hook #31438
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Code Quality
Issues or PRs that relate to code quality
label
May 3, 2021
Size Change: -1.35 kB (0%) Total Size: 1.86 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
May 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I didn't know we removed all of its usage.
jorgefilipecosta
force-pushed
the
remove/use-colors-hook
branch
from
May 26, 2021 15:00
5473194
to
1b41ed2
Compare
jorgefilipecosta
force-pushed
the
remove/use-colors-hook
branch
from
May 26, 2021 16:34
1b41ed2
to
b93caa9
Compare
aaronrobertshaw
added a commit
that referenced
this pull request
May 19, 2022
The only use of these color panel files was removed in #31438.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The __experimentalUseColors react hook is not used anymore by our code it was replaced by the supports mechanism.
The supports hook is now the recommended way of implementing colors and allows what __experimentalUseColors allows so I guess we can remove __experimentalUseColors while it is still experimental.
Part of: #31416.
How has this been tested?
I did a set of smoke tests (mainly color functionality) and verified everything still works expected.