Post/site/template editors: clear selection on iframe html element click, fix bottom click redirect #31385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +18 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Thank you for working on this. The effect on the post editor is subtle but amazing:
Clicking left or right of a block deselects, even if you click in the padding of the body element. It's not working quite as intended in the site editor, alas. I think it's the code that looks for the bottom block, which comes very early on archive pages in the site editor, meaning if you scroll just a little bit, you basically can't deselect:
I understand the problem is related to the "click redirect" — the feature where if you click below the last block it sets focus on the last block. If we can keep that in the post editor, I still think that would be ideal. But if we have to remove that, it might still be worth it. Ultimately I thin it's more important to be able to deselect blocks than it is to easily select the last one. |
ellatrix
force-pushed
the
fix/canvas-click-redirect
branch
from
9859458 to
96b1314
Compare
@jasmussen No, this particular problem in the site editor is not related to the click redirect, it is not added there at all. The problem is that the selection clearer is active on the body element, but not the html element, and the body doesn't extend all the way to the bottom. I've fixed the problem now by also adding it to the html element. |
ellatrix
force-pushed
the
fix/canvas-click-redirect
branch
from
96b1314 to
fec3f0a
Compare
ellatrix
force-pushed
the
fix/canvas-click-redirect
branch
from
fec3f0a to
da4c454
Compare
ellatrix
changed the title
ellatrix
commented
May 16, 2021
|
|
||
| > * { | ||
| cursor: auto; | ||
| } |
There was a problem hiding this comment.
We need to remove the cursor style as we can't apply it to only the bottom padding of an element.
|
Currently seeing these two:
Both of these work really well for me. The site editor has a few small issues but those are unrelated to this PR. I'm a fan, would love to see this land. What's needed to land it? |
|
It works great, so let's merge. There's a small issue with FSE that exists in trunk too where you have to click twice above the first block to clear selection, but I'll have to look into that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #31369. Also fixes the selection clearer below the fold for FSE. It need to be active on the
htmlelement as well, so I built it in the Iframe component.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).