Site Editor: use EditorNotices component for notices #31303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creativecoder
added
[Feature] Site Editor
creativecoder
requested review from
vindl,
jeyip,
mattwiebe,
Addison-Stavlo,
Copons,
david-szabo97 and
apeatling
|
Size Change: -43 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
Copons
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
LGTM! ✨
Thanks for the fix, this simplifies things a lot!
Tests performed:
- Trigger snackbar notice by reverting a customized template.
- Trigger success/error/warning/generic notice by dispatching
wp.data.dispatch( 'core/notices' ).createNotice('success', 'Hello World!')and changing "success" accordingly. - Trigger snackbar notice by dispatching
wp.data.dispatch( 'core/notices' ).createNotice('error', 'Hello World!', { type: 'snackbar' } ).
Everything works as expected!
There currently is a failing e2e, but I'm fairly sure it's unrelated. I've re-run the jobs, hopefully it will sort itself out. Either way, I don't consider it a blocker for the merge.
david-szabo97
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Tested and it works well! 🚢
On mobile, the block toolbar is obscuring the notice. This is unrelated to your PR as this happens in the Post Editor as well. I'll check for an open issue and create one if there is none.
Screen.Recording.2021-04-30.at.8.00.54.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the
EditorNoticescomponent from the@wordpress/editorpackage for displaying notices in the site editor, rather than a custom component.Allows "default" notices to display at the top of the editor, in addition to the "snackbar" notices that are possible now.
How has this been tested?
Checkout this branch and test both types of notices
default
Run in the JS console of your browser
snackbar
Trigger a snackbar notice, such as by inserting a template part
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).