components: Remove wp-g2 fontsize control #31287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: -82.7 kB (-6%) ✅ Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Nice 30% gain in the components package :) |
youknowriad
approved these changes
Apr 28, 2021
I was going to do it in a separate follow up PR 😁 |
With -82.7 kB, we should be back to where we were before 😄 From #27594 (comment):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the wp-g2 font size control and reverts back to the previous implementation. This isn't permanent but gets us a step closer towards removing the wp-g2 dependencies in favor of vanilla emotion. See #30503 for the full plan and how this PR fits into it.
How has this been tested?
Run Gutenberg and ensure that the font size controls work (for example on the Paragraph block).
Screenshots
Types of changes
Non-breaking change/wp-g2 removal.
Checklist:
*.native.jsfiles for terms that need renaming or removal).