Move the block manager to the preferences modal #31191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
changed the title
|
Size Change: -126 B (0%) Total Size: 1.49 MB
ℹ️ View Unchanged
|
4 tasks
|
Big fan! But there's an issue with scrolling the block manager, the toolbar disappears:
Other than that, 👍 👍 |
|
Sticky problem is tricky here as it seems that the There is this PR: https://github.com/WordPress/gutenberg/pull/28394/files that doesn't fix the double sticky part but solves the problem that @jasmussen mentioned. Also I'm not really sure if this affects other places in a way it shouldn't 🤔 |
ntsekouras
reviewed
Apr 27, 2021
|
Another thing is the block manager should be absorbed into the "blocks" section, it doesn't make sense to have "block manager" and "blocks" top levels. |
7 tasks
|
I've looked into moving this one along and there's more than one way to do so. Also, besides the I've made branch of this PR rebased on changes from those PRs above and the result is #32166. It has a few additional changes addressing preceding comments (#31191 (comment), #31191 (review)) and proposed improvements. It's there for testing but intentionally left drafted and sparsely described since the PRs it's based on need vetting first. |
|
@stokesman I think the modal changes now landed, should we include your PRs into the current branch or continue on yours (no preferences from me)? |
|
@youknowriad, I figured the other branch would have an easier rebase and so went ahead and did that. Then it occurred to me the PR #31874 is not needed as there is a easy way to override the |
|
I'm closing this one in favor of #32166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small PR to propose to move the block manager to the preferences modal, these are all "preferences".
At the moment, scrolling is a bit weird, if there are experts with sticky positioning here, please do fix it :)