Fix: Adding buttons should respect the preferred style #31089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
added
[Block] Buttons
This comment has been minimized.
This comment has been minimized.
|
Size Change: +46 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
There's another issue with the template described in #28217, so I wonder if it might be good to remove the template and look for a different way of handling empty buttons blocks. |
This comment has been minimized.
This comment has been minimized.
aristath
changed the title
ntsekouras
reviewed
Jun 21, 2021
Co-authored-by: Nik Tsekouras <[email protected]>
ntsekouras
reviewed
Jun 22, 2021
ntsekouras
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #27217
How has this been tested?
Testing instructions from #31084:
buttonsblock, and notice that the button is not an outline.This PR fixes the above issue, so the 1st button has the right style.
Checklist:
*.native.jsfiles for terms that need renaming or removal).