-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook maybe_inline_styles in the footer #31072
Conversation
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
@carolinan, can you double-check this change? I don't have enough background to tell what's going on here, but it definitely solved the issue for @LukaszJaro which is enough for me to ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been able to reproduce the issue and the PR fixes it. 👍
Description
non-block themes opting in separate styles using
load_separate_block_assets
are currently unable to have inlined styles. This PR fixes the issue by hookinggutenberg_maybe_inline_styles
in the footer.See #31013 (comment) for details.
How has this been tested?
Tested in a classic theme by adding
add_filter( 'load_separate_block_assets', '__return_true' );
.Confirmed in #31013 (comment)
Checklist:
*.native.js
files for terms that need renaming or removal).