Tests: Adds reporter that shows JS test errors on GitHub when executing GitHub workflows #31041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a4c33b5.
ockham
added
the
[Type] Automated Testing
|
Size Change: +3.11 kB (0%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
|
There is a bug in the reporter which means we need to wait more to see it in action:
I'm waiting patiently 😄 |
Yeah, I think it's the |
|
Seems like we are actually generating annotations: https://github.com/WordPress/gutenberg/actions/runs/771200933 They just aren't displayed in the diff 🤔 Wonder if we're doing something wrong with regard to how we pass the filename and/or line and column... |
|
Ah, I see it. We're extracting the wrong line number. From my local run: Note that we're setting whereas the correct location would be I'll try to fix the RegEx. |
|
💥
TODO:
|
This reverts commit 52a24a2.
gziolo
approved these changes
Apr 21, 2021
|
On the note of ANSI colors: I've noticed that Jest provides those as part of the items in the However, the seem to get lost during processing in the reporter 🤔 |
|
I'll ignore the colors for now. I think that it's not specific to this reporter -- Jest normally uses colors to highlight test outcomes in its standard reporters, and those are apparently also lost (stripped by Jest?) in the GHA output. |
gziolo
changed the title
|
Will it work also with e2e tests? it would be more helpful there as they fail more often 😅 |
Ah, great question! I think it should, since they're also Jest-based. However, we'll need to add the reporter to the e2e tests' I'll give it a quick spin 👍 |
|
Pushed a few more commits, and moved the reporter to the @gziolo Care to give it another quick look if the changes I made to files in |
ockham
changed the title
gziolo
reviewed
Apr 23, 2021
packages/e2e-tests/specs/editor/various/inserting-blocks.test.js
Outdated
Show resolved
Hide resolved
Sure thing, everything looks good. I'm very excited about this integration! I made a screenshot and reverted the enforced test failure:
|
Awesome, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Try adding a Jest Reporter that produces an output format for GitHub annotations.
Based on jestjs/jest#11320 (but ported the TypeScript to plain ol' JS since I couldn't get the TS based reporter to work). Quoting that PR:
This PR is mostly meant to demo that feature; ideally, we'll be able to tweak it and merge it. If jestjs/jest#11320 gets merged, we can then consider switching to that, once there's a Jest version that includes it.
How has this been tested?
See diff view: There should be an annotation below the failing assertion.
To test locally, run
to see the GHA-specific output format. Confirm that if you omit the
GITHUB_ACTIONSenv var, you won't see that output.Screenshots
FYI @gziolo