Fix for issue 2635 #3104
Closed
Fix for issue 2635 #3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Oct 23, 2017
blocks/library/button/editor.scss
Outdated
| @@ -15,7 +15,7 @@ $blocks-button__height: 46px; | |||
| z-index: 2; | |||
| top: $blocks-button__height + 2px; | |||
| left: 50%; | |||
| transform: translateX( -50% ); | |||
There was a problem hiding this comment.
Which bug is this fixing exactly? and why 13%?
ShreyaSingh10
force-pushed
the
css-fix-2635
branch
from
d714fbd to
7567572
Compare
|
Issue #2635 is fixed, so we can close this PR. |
|
Thanks for your work on this PR @ShreyaSingh10 The issue is fixed now. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the overlapping problem with the WordPress admin sidebar.
How Has This Been Tested?
Tested with chrome inspector too.