Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor: Fix the position of vertical add new block in RTL mode #31035

Conversation

sunnyssr
Copy link
Contributor

Description

Fix the position of add new block / block insertor in vertical orientation in RTL mode

How has this been tested?

Steps:-

  1. Go to Settings
  2. Switch your language to any RTL language
  3. Go to Gutenberg editor.
  4. Try inserting the block between two blocks.

Screenshots

Before:
screenshot-localhost_8888-2021 04 21-16_10_10
screenshot-localhost_8888-2021 04 21-16_09_48

After:
image

Types of changes

closes #30867

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

cc @Ryokuhi @youknowriad

Pull request which is related to this: #27860

@sunnyssr sunnyssr requested a review from ellatrix as a code owner April 21, 2021 10:41
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Thanks a lot for the fix.

@youknowriad youknowriad merged commit ded974c into WordPress:trunk Apr 21, 2021
@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. Internationalization (i18n) Issues or PRs related to internationalization efforts labels Apr 21, 2021
@github-actions github-actions bot added this to the Gutenberg 10.5 milestone Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect position of "add new block/block list" in rtl mode
2 participants