Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post excerpt: Update read more placeholder text #30959

Merged
merged 2 commits into from
May 7, 2021

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Apr 19, 2021

Description

For #29168
Update the post excerpts read more placeholder from "Read more..." to Add "read more" link text

How has this been tested?

By manually adding a post excerpt block

Screenshots

Types of changes

Enhancement

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@carolinan carolinan added the [Block] Post Excerpt Affects the Post Excerpt Block label Apr 19, 2021
@carolinan carolinan requested a review from ajitbohra as a code owner April 19, 2021 11:34
@carolinan carolinan added Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code Needs Copy Review Needs review of user-facing copy (language, phrasing) labels Apr 19, 2021
@kristastevens
Copy link

Hello @carolinan, thanks for the ping! I have one small suggestion, to add quotations around "read more" in your CTA:

Add "read more" link text

I think adding the quotation marks might help a little with understanding the action they need to take here.

@carolinan carolinan removed the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Apr 29, 2021
@carolinan carolinan requested a review from aristath May 7, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Excerpt Affects the Post Excerpt Block Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants