[RNMobile] Update theme updates to use the approach that guarantees delivery #30847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipsnyder
added
the
Mobile App - i.e. Android or iOS
2 tasks
|
Size Change: 0 B Total Size: 1.46 MB ℹ️ View Unchanged
|
|
Thanks for starting this @chipsnyder! Can you add a bit more context to this change?
Thank you! |
|
Hey @enejb 👋 Yup the change here is to modify The The way the bridge between native and ReactNative works means that certain calls can be lost while the editor initializes. So the The |
antonis
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
Great work @chipsnyder 👍
This LGTM according to your explanation here and works as expected (tested via wordpress-mobile/WordPress-iOS#16282) 🎉
|
Thanks for the explanation @chipsnyder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#3163
Related PRs:
📓 This PR can merge independent of any of the other changes.
Description
This is connected to the refactor work being done in wordpress-mobile/WordPress-iOS#16282. Previously the theme update events could be lost if the editor was still starting up and required a refresh call. With the "guaranteed" delivery that was added back in wordpress-mobile/gutenberg-mobile#2366, we can now set the theme and trust its delivery will happen.
How has this been tested?
This can be tested by running the regression test suite:
Types of changes
Bug Fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).