Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RNMobile] Search Block: Add UI Tests and make available to production! #30783

Merged
merged 31 commits into from
Apr 26, 2021
Merged

[RNMobile] Search Block: Add UI Tests and make available to production! #30783

merged 31 commits into from
Apr 26, 2021

Commits on Apr 7, 2021

  1. Add initial basic UI test for search block 

    - Had to take the search block out of devOnly mode for this to work.
    @AmandaRiu
    AmandaRiu committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    2da4ec0 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. Search block UI tests -- wip

    @AmandaRiu
    AmandaRiu committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    1f067ec View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. Work in progress

    @AmandaRiu
    AmandaRiu committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    7e51bf6 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2021

  1. Add testIDs for iOS UI tests

    @AmandaRiu
    AmandaRiu committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    15c2fbf View commit details
    Browse the repository at this point in the history

  2. Simplify access to block child components

    @AmandaRiu
    AmandaRiu committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    0d2a822 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Finished iOS and Android tests for editing child elements

    @AmandaRiu
    AmandaRiu committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    cad8a0f View commit details
    Browse the repository at this point in the history

  2. Add method to open block settings and dismiss

    @AmandaRiu
    AmandaRiu committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    4f7065c View commit details
    Browse the repository at this point in the history

  3. Add Search block settings UI tests

    @AmandaRiu
    AmandaRiu committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    65d07cf View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. Clean up and optimize Search block tests

    @AmandaRiu
    AmandaRiu committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    c9c400d View commit details
    Browse the repository at this point in the history

  2. Add unit tests to check for testIDs

    @AmandaRiu
    AmandaRiu committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    3ba23c6 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. Move button below input if width greater than 50% 

    - Re-evaluate during orientation changes as well
    @AmandaRiu
    AmandaRiu committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    056ba95 View commit details
    Browse the repository at this point in the history

  2. Use long button styles only when container or button width changes

    @AmandaRiu
    AmandaRiu committed Apr 14, 2021
    Configuration menu
    Copy the full SHA
    963e6f3 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. Update unit-test snapshots

    @AmandaRiu
    AmandaRiu committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    1dc8fdb View commit details
    Browse the repository at this point in the history

  2. Remove unused code

    @AmandaRiu
    AmandaRiu committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    e4a5461 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'rnmobile/search-block-long-button-text' into rnmobile/s… 

    …earch-block-ui-tests
    @AmandaRiu
    AmandaRiu committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    34752e7 View commit details
    Browse the repository at this point in the history

  4. Update unit-test snapshot

    @AmandaRiu
    AmandaRiu committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    84941e4 View commit details
    Browse the repository at this point in the history

  5. Add changelog note for Search Block release

    @AmandaRiu
    AmandaRiu committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    abfde8a View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. Merge branch 'trunk' into rnmobile/search-block-ui-tests

    @AmandaRiu
    AmandaRiu committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    d655e88 View commit details
    Browse the repository at this point in the history

  2. Updated unit-test snapshots for changes in long text

    @AmandaRiu
    AmandaRiu committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    fe44004 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Merge branch 'trunk' into rnmobile/search-block-ui-tests

    @AmandaRiu
    AmandaRiu committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    78a47c4 View commit details
    Browse the repository at this point in the history

  2. Remove unit-tests for testIDs

    @AmandaRiu
    AmandaRiu committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    fe0a2d2 View commit details
    Browse the repository at this point in the history

  3. Update packages/react-native-editor/CHANGELOG.md 

    Co-authored-by: David Calhoun <[email protected]>
    @AmandaRiu @dcalhoun
    AmandaRiu and dcalhoun authored Apr 20, 2021
    Configuration menu
    Copy the full SHA
    52a41b9 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. Track when a screenreader is active

    @AmandaRiu
    AmandaRiu committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    ddc4f3d View commit details
    Browse the repository at this point in the history

  2. Set accessibilityLabel to match testID when screenreader is not active

    @AmandaRiu
    AmandaRiu committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    b3e70e3 View commit details
    Browse the repository at this point in the history

  3. Access search block elements by accessibilityID

    @AmandaRiu
    AmandaRiu committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    e4f0aea View commit details
    Browse the repository at this point in the history

  4. Update unit test snapshot

    @AmandaRiu
    AmandaRiu committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    faaa933 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Use undefined instead of null so it doesn't show up in snapshot

    @AmandaRiu
    AmandaRiu committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    2e7a4ef View commit details
    Browse the repository at this point in the history

  2. Remove unused code

    @AmandaRiu
    AmandaRiu committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    e2e5a20 View commit details
    Browse the repository at this point in the history

  3. Remove testID as no longer needed for iOS e2e

    @AmandaRiu
    AmandaRiu committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    17a78d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Remove forced clear text option and expand sleep 

    Since the search block fields are already empty, accept whatever the
default value for `clear` which is `true` for Android and `false` for
iOS. Also add a sleep when changing animated settings options on Android to
avoid flakiness.
    @AmandaRiu
    AmandaRiu committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    9bbe965 View commit details
    Browse the repository at this point in the history

  2. Avoid test flakiness by making search block fields 

    empty before adding text.
    @AmandaRiu
    AmandaRiu committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    e552cf4 View commit details
    Browse the repository at this point in the history