-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post excerpt: Don't print the wrapper when there is no excerpt #30616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
changed the title
Post: excerpt: Don't print the wrapper when there is no excerpt
Post excerpt: Don't print the wrapper when there is no excerpt
Apr 8, 2021
Size Change: +41.1 kB (+3%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
carolinan
added
[Block] Post Excerpt
Affects the Post Excerpt Block
Good First Review
A PR that's suitable for someone looking to contribute for the first time by reviewing code
labels
Apr 8, 2021
aristath
force-pushed
the
update/post-excerpt
branch
from
June 14, 2021 07:57
fe97489
to
be8ecbc
Compare
aristath
approved these changes
Jun 14, 2021
carolinan
removed
the
Good First Review
A PR that's suitable for someone looking to contribute for the first time by reviewing code
label
Sep 28, 2021
The PR needs to be rebased to resolve conflicts 👍 |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial fix for #30571
Removes the unnecessary wrapper on the front when there is no excerpt.
Removes the wrapper for the read more link (
wp-block-post-excerpt__more-text
) if there is no read more text.How has this been tested?
markup for the read more link is not printed.
Types of changes
Bugfix/enhancement
Checklist:
*.native.js
files for terms that need renaming or removal).