-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handbook: Updated documentation to reflect the output created currently by npx @wordpress/create-block gutenpride #30353
Conversation
…@wordpress/create-block gutenpride.
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @janw-me! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
@mkaz As we talked about last week, I updated the docs and here is the pull. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janw-me This is great work, thank you so much for your time updating the tutorial with the latest. I walked through it all and it looks good.
I think you're right simplifying the SCSS part since it's already discussed in the build, this change recently to be a default, so it was another area a little outdated.
Thanks again, great first contribution 👍
Congratulations on your first merged pull request, @janw-me! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
That's fantastic work, thank you for bringing this tutorial up to date 👏🏻 |
Thanks for accepting my edits. |
Description
I updated the the documentation based on the output of
npx @wordpress/create-block gutenpride
Types of changes
There is one section I made real changes. I deleted the Use Sass for Style section.And I updated the instructions to include the compilation.
My reasoning is as following; In previous steps we did explain building, to get here a user already should have build the plugin at least once.The file names of the sass files are a lot more clear. Even if a user does not know sass the example code only uses normal css, and normal css is save to enter in sass.
I hope this entry gets accepted.